chore: add polkadot + ksm grants integration #8269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- switch KSM to it's own chain ID (59) - tweak bounty flow to treat KSM and DOT as diff chains in frontend - add KSM + DOT support in grants
thelostone-mc
requested review from
amustapha,
chibie,
frankchen07,
octavioamu and
PixelantDesign
as code owners
|
This still looks like a draft. Is it ready? |
|
@aamustapha yup it is ready! |
amustapha
suggested changes
Feb 3, 2021
| if (error) { | ||
| vm.updatePaymentStatus(grant.grant_id, 'failed'); | ||
| _alert('Please ensure you\'ve connected your polkadot extension to Gitcoin', 'error'); | ||
| console.log(error); |
There was a problem hiding this comment.
😬 debugger line forgotten.
There was a problem hiding this comment.
that was intentional ! just so that the error stays ! cause this is behind a staff flag -> will remove this next week once folks test and we are sure it's smooth
amustapha
approved these changes
Feb 3, 2021
|
@aamustapha recreated the migration file as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing Checklist
Bounty
Grants
Testing
KSM has some issues which need to follow up with polkadot team. It is breaking in liveKSM has been fixed by upgrading the bundle versions.
DOT seems to work fine on bounties and grants
https://share.vidyard.com/watch/fqZRThbNu1xRpphA7uCoki?